This may already have been discussed (in which case moderators, feel free to close it!) But I have been getting some interesting but repeatable results with the A/D converter on my Particle Core. Basically, when changing the sample time with setADCSampleTime, I’m a little confused. From my readin…

[image] BDub: I'm going to add this as a firmware issue to work through in the near future. I know we can make this better @BDub . I don't see any issues dating 27 days back on this subject. But if this counts as cross-posting (here and GitHub issues), by all means chew me out :smile: Basi…

@BDub , @satishgn , both of your names are in the code file, so I have permission to pester you! Just for good measure, @bko , @ScruffR , @kennethlimcp …the solution to the ADC problem is here! I totally disabled the slow-interleaved ADC mode in a month-old LATEST build, modifying \core\adc_hal.c: HA…

I did all of my rigorous testing before dual slow interleaved mode and liked the results back then as well. You have my vote to revert the ADC mode :wink: I don’t believe it was DMA driven before, so your modifications that keep it DMA driven may be worthwhile. Do you want to wrap up your changes…

[image] BDub: Do you want to wrap up your changes in a PR so that we can more easily test/compare the changes? What is a PR? I'm pretty sure it isn't public relations :stuck_out_tongue_winking_eye:. Here's my modified copy of the last two subroutines in firmware-latest\hal\src\core\adc_hal.…

@WebDust21 , PR = pull request in https://github.com/spark/firmware

@wesner0019 , @BDub …which branch should I make the pull request in? LATEST, DEVELOP, MASTER…??? EDIT: I’m utterly confused as to how GitHub works.

If you’re up for it please create a PR against the develop branch :sunglasses: latest will probably merge just fine as well, if you don’t want to navigate the extra stuff required for develop.

[image] BDub: If you're up for it Can you tell me how many feet there are, which foot goes in front of the other one, with what sequence, which angle, which weight, and at what time? I am absolutely, completely and totally confounded as to how to use GitHub. To answer...no, I'm not up for i…

Ok no worries @WebDust21 your code posted above should be pretty easy to insert locally and test. If you’d like to learn more about Git and Github, there are literally a bazillion videos on youtube. You can also read the various official docs (harder).

This thread started recently and I have high hopes that we can get more folks up-to-speed on github. [image] How to contribute to the community Getting Started I really love the fact that Particle is so open to invite us all in to contribute to both documentation and the …

Interesting results from various ADC sample times

Hardware

bko August 10, 2015, 4:42pm 22

This thread started recently and I have high hopes that we can get more folks up-to-speed on github.

Topic		Replies	Views
Fast ADC readings Firmware photon	11	2300	October 28, 2024
Odd analog readings (part 2) Troubleshooting	63	19477	May 22, 2017
Why dual slow interleaved? Firmware	12	6744	July 19, 2016
Low Electron ADC Readings Troubleshooting	8	2153	March 3, 2017
Issues while using ADC with DMA(Photon Audio3 example) on E Series Firmware e-series	13	1302	August 7, 2021

Interesting results from various ADC sample times

Related topics