@StngBo, there is no need to change the library name in the library.properties file. What you do need to add after the typical include "Particle.h" is include "Arduino.h" to add the necessary Arduino environment "stuff" and for the code to compile.
I created a new Particle project in VSCode, copied the note-arduino-master code from github into a new lib directory and copied the code from Example1_NotecardBasics.ino into the ino file created when I made the project. I then added the include "Arduino.h" as indicated above, configured the project for a BSoM using DeviceOS 6.3.0 and compiled without error.
Thanks for that, I have got it to successfully compile, but still having issues using the code and just trying to troubleshoot.
Obviously you are unable to help with the troubleshooting of the devices, but did you have the error cannot open source file "Notecard.h" in your example project?