Using SparkJS in browser

Moors7 · December 29, 2014, 12:10am

It was meant to be more of a proof of concept to show that it was actually working. If you check the console, you’ll see that it returns your accesstoken, which you can then use to get your functions/variables and fire them.

Once you’ve loaded the script, you should be able to use the functions mentioned in the docs. The following things work for me, which lead me to believe the rest should work as well.

<html>
  <head>
    <title>Spark Login Example</title>    
  </head>

  <body>
<!--    <div id="spark-login"></div>   -->
  </body>	
  
  <script src="http://cdn.jsdelivr.net/sparkjs/0.2.0/spark.min.js"></script>
    <script>
	/* ===========================================================
	var callback = function(err, body) {
	  console.log('API call login completed on callback:', body);
	};

	spark.login({username: 'name@provider.com', password: 'YourPassword'}, callback);
	*/// =========================================================
	
	
	/*
	spark.login({username: 'name@provider.com', password: 'YourPassword'}).then(
	  function(token){
		console.log('API call completed on promise resolve: ', token);
	  },
	  function(err) {
		console.log('API call completed on promise fail: ', err);
	  }
	);
	*///==========================================================
	
	spark.on('login', function(err, body) {
		console.log('API call completed on Login event:', body);
	  
		var devicesPr = spark.listDevices();

		devicesPr.then(
		  function(devices){
			console.log('Devices: ', devices);
		  },
		  function(err) {
			console.log('List devices call failed: ', err);
		  }
		);
		
		var devicesAt = spark.getAttributesForAll();

		devicesAt.then(
		  function(data){
			console.log('Core attrs retrieved successfully:', data);
		  },
		  function(err) {
			console.log('API call failed: ', err);
		  }
		);
		
		
	});

	spark.login({username: 'name@provider.com', password: 'YourPassword'});
		
	/*
      sparkLogin(function(data) {
        console.log(data);
      });
	  
	*/
    </script>
</html>

That produces the following:

Using that, you should be able to call the functions of your liking.

semaja2 · December 29, 2014, 3:32am

Thanks for that, I was able to get that working fine, however spark.getDevice doesn’t appear to be working? I had a look in the spark.js file and couldn’t find any reference of that function?

  <html>
  <head>
    <title>Spark Login Example</title>    
  </head>

  <body>
  </body>	
  
  <script src="http://cdn.jsdelivr.net/sparkjs/0.2.0/spark.min.js"></script>
    <script>

	
	spark.on('login', function(err, body) {
		console.log('API call completed on Login event:', body);
	  
		spark.listDevices(function(err, devices) {
			  var device = devices[0];
			
			  console.log('Device name: ' + device.name);
			  console.log('- connected?: ' + device.connected);
			  console.log('- variables: ' + device.variables);
			  console.log('- functions: ' + device.functions);
			  console.log('- version: ' + device.version);
			  console.log('- requires upgrade?: ' + device.requiresUpgrade);
			});

		spark.getDevice('54ff6e066678574918123456', function(err, device) {
			  console.log('Device name: ' + device.name);
			});	
		
	});

	//spark.login({username: 'xxx@xxx.net', password: 'xxx'});
	spark.login({accessToken: '57a8aed6971a0e997a659f467fc5cbb4ea123456'});
	
	/*
      sparkLogin(function(data) {
        console.log(data);
      });
	  
	*/
    </script>
</html>

This is the console log

[Log] API call completed on Login event:  (test.html, line 14)
Object

[Error] TypeError: undefined is not a function (evaluating 'spark.getDevice('54ff6e066678574918123456', function(err, device) {
			  console.log('Device name: ' + device.name);
			})')
	(anonymous function) (test.html, line 27)
	emit (spark.min.js, line 2)
	emitAndCallback (spark.min.js, line 1)
	(anonymous function) (spark.min.js, line 1)
	(anonymous function) ([native code], line 0)
	login (spark.min.js, line 1)
	global code (test.html, line 34)
[Log] Device name: tasty_station (test.html, line 19)
[Log] - connected?: false (test.html, line 20)
[Log] - variables: undefined (test.html, line 21)
[Log] - functions: undefined (test.html, line 22)
[Log] - version: undefined (test.html, line 23)
[Log] - requires upgrade?: undefined (test.html, line 24)

semaja2 · December 29, 2014, 9:02pm

Ok so I worked it out, appears the documentation is incomplete and still references the older 0.2.0 release rather than the 0.2.4 release which is when the getDevice function was added

<script type="text/javascript" src="//cdn.jsdelivr.net/sparkjs/0.2.0/spark.min.js">

Release History

Version 0.1.0 Initial release Version 0.2.1 Publishing, test release Version 0.2.2 Pulling in getDevice Version 0.2.4 adding some basic parsing to the getEventStream function, now returns an object

How do we go about submitting a bug report on the documentation?

Moors7 · December 29, 2014, 9:33pm

You’re absolutely correct! I hadn’t noticed that myself since I have the library locally. You can make Pull Request by clicking the “edit this page” button at the top right of the docs page.
Seeing as I apparently have editorial rights on the docs, I went ahead and changed it. I guess the docs get updated every X time, so it should probably show up in a while. (Could you verify/check this @kennethlimcp?)

semaja2 · December 29, 2014, 9:41pm

Thanks that looks much better now

Is it possible to also get your second example included in the documentation as that example instantly provided all the components I needed to get my code working

<html>
  <head>
    <title>Spark Login Example</title>    
  </head>

  <body>
<!--    <div id="spark-login"></div>   -->
  </body>	
  
  <script src="http://cdn.jsdelivr.net/sparkjs/0.2.4/spark.min.js"></script>
    <script>
	/* ===========================================================
	var callback = function(err, body) {
	  console.log('API call login completed on callback:', body);
	};

	spark.login({username: 'name@provider.com', password: 'YourPassword'}, callback);
	*/// =========================================================
	
	
	/*
	spark.login({username: 'name@provider.com', password: 'YourPassword'}).then(
	  function(token){
		console.log('API call completed on promise resolve: ', token);
	  },
	  function(err) {
		console.log('API call completed on promise fail: ', err);
	  }
	);
	*///==========================================================
	
	spark.on('login', function(err, body) {
		console.log('API call completed on Login event:', body);
	  
		var devicesPr = spark.listDevices();

		devicesPr.then(
		  function(devices){
			console.log('Devices: ', devices);
		  },
		  function(err) {
			console.log('List devices call failed: ', err);
		  }
		);
		
		var devicesAt = spark.getAttributesForAll();

		devicesAt.then(
		  function(data){
			console.log('Core attrs retrieved successfully:', data);
		  },
		  function(err) {
			console.log('API call failed: ', err);
		  }
		);
		
		
	});

	spark.login({username: 'name@provider.com', password: 'YourPassword'});
		
	/*
      sparkLogin(function(data) {
        console.log(data);
      });
	  
	*/
    </script>
</html>

Moors7 · December 29, 2014, 9:49pm

Glad I could be of assistance !
Technically I could paste it in there, but I guess it’ll have to be cleaned up a fair bit, and have some peer review with the other Elites before I try that. Don’t want to mess up the docs, but I agree that some more examples might not be out of place. My example would’ve also helped me when I just started out (which is not too long ago ;P).
You can of course always make Pull Requests if you feel you’ve got something meaningful to add. I’ll take a look at this as well

semaja2 · December 30, 2014, 8:32am

Ok so I am back… appears none of my call back functions will be accepted by the spark.js

spark.on('login', function(err, body) {
  console.log('API call completed on Login event:', body);
  spark.getEventStream(false, false, function(data) {
	  console.log("Event: " + data);
	});
});

spark.login({accessToken: '57a8aed6971a0e997a659f467fc5cbb41234567});

[Log] API call completed on Login event: (test.html, line 9)
Object

[Error] Error: Bad callback given: undefined
request (spark.min.js, line 1)
getEventStream (spark.min.js, line 1)
getEventStream (spark.min.js, line 1)
(anonymous function) (test.html, line 10)
emit (spark.min.js, line 2)
emitAndCallback (spark.min.js, line 1)
(anonymous function) (spark.min.js, line 1)
(anonymous function) ([native code], line 0)
login (spark.min.js, line 1)
global code (test.html, line 15)

Moors7 · December 30, 2014, 10:00pm

That indeed is strange. That I’ve looked at the library but can’t figure out why it’s giving the error. I guess it’s time to call in the reinforcements: @kennethlimcp @peekay123 @Dave @ScruffR @bko Could one of you perhaps take a look at it? The code above is basically the same as in the examples provided.

kennethlimcp · December 30, 2014, 10:57pm

@solojavier might be able to quickly look at this but I’ll test it as well

bko · December 30, 2014, 11:00pm

Nothing really jumped out at me. Where you have

<script scr="...path to .js..."></script>

I always try to help out with more hints just in case:

<script scr="...path to .js..." type="text/javascript" charset="utf-8"></script>

If I were debugging this, I would do it using the Chrome Javascript debug console which is quite nice.

semaja2 · December 30, 2014, 11:23pm

I did troubleshoot before I posted but forgot to include the details, it seems all the Spark event functions have the same issue as they all link to a common function that seems to be failing?

Can anyone confirm they are having the same issues when they put the code into a HTML page? I tried to keep the snippet as simple as possible to allow it to be easily debugged

kennethlimcp · December 30, 2014, 11:41pm

@semaja2,

This is kind of messy looking at only snippets of your code. Can you have a full sample of the non-working code?

My test on nodejs worked fine so far

Moors7 · December 31, 2014, 12:10am

This should be a ‘complete’ example, which doesn’t work:

<html>
  <head>
    <title>Spark Login Example</title>    
  </head>

  <body>
	Open the console to see output.
  </body>	
  
  <script src="http://cdn.jsdelivr.net/sparkjs/0.2.4/spark.min.js" type="text/javascript" charset="utf-8"></script>
    <script>
	spark.on('login', function() {
	    console.log("I've just logged in. Now I'll try to subscribe to all events.");
		
	    //Get all events
	    spark.getEventStream(false, false, function(data) {
		console.log("Event: " + JSON.stringify(data));
	    });
/*
	    //Get your devices events
	    spark.getEventStream(false, 'mine', function(data) {
	        console.log("Event: " + JSON.stringify(data));
	    });
	   
            //Get test event for specific core
	    spark.getEventStream('test', 'CORE_ID', function(data) {
		console.log("Event: " + JSON.stringify(data));
	    });
*/
	});

        // Login as usual
        spark.login({ username: 'mail@provider.com', password: 'pass'});
        //spark.login({ accessToken: '012345' });
		
    </script>
</html>

Several other functions work fine, although the listDevices gave some problems since it doesn’t return the functions/variables like it’s supposed to. getDevice on the other hand does work.

kennethlimcp · December 31, 2014, 12:52am

@Moors7 and @semaja2,

I’m really just guessing that the way spark.min.js V0.2.4 was bumped did not end up in cdn…

@Dave updated the file AFTER bumping the version to V0.2.4 so i’m guessing the change would not have been picked up: https://github.com/spark/sparkjs/commit/20c89ad985e3a388c77ca1dd12c04f7cad33d164

Using NodeJS works since the library is pulled from the github repo directly during install so we are safe to conclude that the functions works ok…

Let’s wait for an official Spark reply for now.

semaja2 · December 31, 2014, 2:05am

I actually tried the latest spark.min.js from the git and it still has the same issue, I wonder if there is a bug that only shows up when using it outside of NodeJS?

Dave · December 31, 2014, 6:09am

Hmm, strange! I’ll dive into it as soon as I get a chance tomorrow, I added an issue for this here:

Thanks,
David

Moors7 · January 15, 2015, 3:25pm

Hey @dave, did you have a chance to look at this already? The eventStream is still acting weird. I tried to use the code you supplied yesterday in the browser, but I keep getting errors about the callback functions.
Using this (from the docs):

spark.getEventStream(false, false, function(data) {
    console.log("Event: " + data);
});

gives me this error in the console:

Potentially unhandled rejection [1] Error: Bad callback given: undefined
    at request (http://cdn.jsdelivr.net/sparkjs/0.2.4/spark.min.js:1:23577)
    at SparkApi.getEventStream (http://cdn.jsdelivr.net/sparkjs/0.2.4/spark.min.js:1:7112)
    at Spark.getEventStream (http://cdn.jsdelivr.net/sparkjs/0.2.4/spark.min.js:1:21683)
    at file:///C:/Users/jordy/Documents/sparkjs/events.html:17:10
    at http://cdn.jsdelivr.net/sparkjs/0.2.4/spark.min.js:1:12041
    at tryCatchReject (http://cdn.jsdelivr.net/sparkjs/0.2.4/spark.min.js:7:13954)
    at runContinuation1 (http://cdn.jsdelivr.net/sparkjs/0.2.4/spark.min.js:7:13469)
    at Fulfilled.when (http://cdn.jsdelivr.net/sparkjs/0.2.4/spark.min.js:7:10707)
    at Pending.run (http://cdn.jsdelivr.net/sparkjs/0.2.4/spark.min.js:7:9155)
    at runQueue (http://cdn.jsdelivr.net/sparkjs/0.2.4/spark.min.js:6:24063)

JSchrempp · January 15, 2015, 3:46pm

I was never able to get Spark library streaming to work in browser Javascript. I do have it working without the Spark function. Here’s the code I used. It calls my function processPublishNotificationGroup() when events arrive. With any amount of TTL in your messages the Spark Cloud might return several Publish messages from your core in any one notification. I have my spark core put a message number in each Publish so that my code can keep track of events it has already handled.

startMonitoring = function () {

    logAdd("entered startMonitoring");

    var eventMonitor = new XMLHttpRequest();

    eventMonitor.onreadystatechange = function() {

        var data = eventMonitor.responseText;
        //console.log(data);

        if (data.length > 5) {

            processPublishNotificationGroup(data);

        }

    }

    var accessToken = window.spark.accessToken;

    eventMonitor.open("GET","https://api.spark.io/v1/devices/events/SISEvent?access_token=" + accessToken
    ,true);

    eventMonitor.send();

},

Moors7 · January 15, 2015, 4:05pm

Thanks for sharing!
I’ve been using this in my MEAN application, to log them to my MongoDB database:

var requestObj = request({
    uri: 'https://api.spark.io/v1/devices/events?access_token=<<<ACCESSTOKEN HERE>>>',
    method: 'GET'
});

var processItem = function(arr) {
    var obj = {};
    for(var i = 0; i < arr.length; i++) {
        var line = arr[i];
 
        if (line.indexOf('event:') === 0) {
            obj.name = line.replace('event:', '').trim();
        }
        else if (line.indexOf('data:') === 0) {
            line = line.replace('data:', '');
            obj = extend(obj, JSON.parse(line));
        }
    }
// ======== saving to database, irrelevant for SSE =========
    var SSE = mongoose.model('Sselog', SselogSchema);

	//var dht = new Schema(Dhts);
	var objData = {
		name: obj.name,
		data: JSON.parse(obj.data),
		publishtime: obj.published_at,
		coreid: obj.coreid,				
	};
	
	var DataToBeSaved = new SSE(objData);
	DataToBeSaved.save();
//======== End of databse save =======================

	console.log(objData.data);
};

var chunks = [];
var appendToQueue = function(arr) {
    for(var i = 0; i < arr.length; i++) {
        var line = (arr[i] || '').trim();
        if (line === '') {
            continue;
			//console.log(arr);
        }
        chunks.push(line);
        if (line.indexOf('data:') === 0) {
            processItem(chunks);
            chunks = [];
        }
    }
};
 
var onData = function(data) { 
    var chunk = data.toString();
	//  console.log('DATA: \n' + data)
	//	console.log('chunk: \n' + chunk);
	//	console.log('chunk split: \n' + chunk.split('n'));
	//	console.log('==========================');
    appendToQueue(chunk.split('\n'));
};

requestObj.on('data', onData);

I blatantly stole this from the [CLI][1], so all credits to the guys at Spark again I was just hoping that the library would get fixed, since that would look a whole lot neater
[1]: https://github.com/spark/spark-cli/blob/master/js/commands/SubscribeCommand.js

Dave · February 3, 2015, 8:13pm

Hey All,

Just a heads up that a new version of SparkJS went out yesterday that fixes the getEventStream callback error.

Thanks!
David